[DO NOT MERGE] - Test QoR check comment with a real PR - #4382
Closed
migueldalberto wants to merge 6 commits into
Closed
[DO NOT MERGE] - Test QoR check comment with a real PR#4382migueldalberto wants to merge 6 commits into
migueldalberto wants to merge 6 commits into
Conversation
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Miguel Dalberto Pedro <miguel.pedro@precisioninno.com>
Signed-off-by: Miguel Dalberto Pedro <miguel.pedro@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Jenkinsfile to reference a feature branch for the shared library and updates the OpenROAD subproject commit. The review feedback correctly advises against using a feature branch in the Jenkinsfile to prevent build instability, suggesting a revert to the stable main branch.
| @@ -1,4 +1,4 @@ | |||
| @Library('utils@main') _ | |||
| @Library('utils@inline-check-pr-comment') _ | |||
Contributor
There was a problem hiding this comment.
Referencing a feature branch (inline-check-pr-comment) for the shared library can lead to build instability. Use a stable version or the main branch for production pipelines.
@Library('utils@main') _
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.